search

jenkinsci / nomad-plugin

Nomad cloud plugin for Jenkins
https://plugins.jenkins.io/nomad/
MIT License
56 stars 41 forks source link

Support nomad constraints #15

Closed gabordugov closed 5 years ago

gabordugov commented 7 years ago

Hey it would be great if this plugin also supports nomad constraints https://www.nomadproject.io/docs/job-specification/constraint.html . It will allow to restrict list of nodes where jenkins slave can be launched. For example, if nomad manages Linux and Windows nodes at the same time and we want to launch Jenkins slave in docker container built for Linux, it will be necessary to avoid launching it on Windows hosts. What do you think?

antweiss commented 7 years ago

I agree this would be a welcome addition - we currently have an issue with some very resource-heavy jobs that we would only want to send to specific nodes (those with more horsepower). I'll see if can look into this but don't expect this to be fast.

lucalandi commented 7 years ago

This would be a really useful feature. I would be more than happy to contribute.

jippi commented 7 years ago

@lucalandi amazing ! :)

scarvel8 commented 7 years ago

I have just opened a pull request that adds this functionality: https://github.com/jenkinsci/nomad-plugin/pull/17

jovandeginste commented 6 years ago

@jippi any reason not to merge the PR?

jamesdmorgan commented 6 years ago

Looking forward to this addition. Thanks to all those involved

vincenthuynh commented 5 years ago

Built the plugin off master with mvn install and uploaded to Jenkins. Had to update pom.xml to match my nomad version but the constraint property works! Thanks @scarvel8 !

peimanja commented 5 years ago

Why the latest plugin available on Jenkins is 0.4? so many commits have already been merged since then. @vincenthuynh How did you manage to build the plugin? mine keeps failing from master.

phedoreanu commented 5 years ago

Closing as #17 is merged.