Add docker private registry authentication support

jenkinsci / nomad-plugin

Nomad cloud plugin for Jenkins

https://plugins.jenkins.io/nomad/

MIT License

56 stars 41 forks source link

Add docker private registry authentication support #2

Closed antweiss closed 8 years ago

antweiss commented 8 years ago

This will allow to pull slave images from a private docker registry if docker driver is selected.

iverberk commented 8 years ago

Are you okay with me changing the username/password to default empty string values? I'd like to get a new release out with a number of enhancements. I'll resolve the conflicts as well.

antweiss commented 8 years ago

Hi Ivo! Sure - it's definitely a cleaner approach to default them to empty strings. Let me know when you add this - we need it for our environment and are using a homegrown version until this gets released. Thanks a lot for your plugin.