search

jenkinsci / nomad-plugin

Nomad cloud plugin for Jenkins
https://plugins.jenkins.io/nomad/
MIT License
56 stars 41 forks source link

Fixing Issue with Orphaned Agents and configurable startup timeout (#1) #37

Closed aphill70 closed 5 years ago

aphill70 commented 6 years ago

Adding Configurable Agent Startup Timeout for workers. This was simply an addition to the Jelly file and a variable in NomadCloud

Fixed a bug that resulted in Agents being orphaned on the Jenkins UI. I debated between throwing the exception or just returning null from the provision call. I ended feeling like the Exception was correct however more than happy to put a null return if that is the more correct way.

Not sure how to exclude the cirlcleci from my fork. If i need to i can remove it

jovandeginste commented 5 years ago

@aphill70 you could add the filename to .gitignore?

aphill70 commented 5 years ago

@jovandeginste I assume you are referring to the circleci file? I have removed it if so

jovandeginste commented 5 years ago

@aphill70 yes, sorry for being unclear ...

lmasaya commented 5 years ago

We could definitely use this change. I'm trying to launch a slave across AWS regions and 1 minute timeout is terminating slave before it actually gets to run

aphill70 commented 5 years ago

I will see if i can fix the conflicts tomorrow didn't realize it had drifted

aphill70 commented 5 years ago

@lmasaya Sorry this took a bit longer but I think I got everything working again

peimanja commented 5 years ago

@aphill70 Thanks a lot! You're a lifesaver. Are you able to look at #47 as well? It prevented us from enabling ACL on our Nomad cluster which is one of the requirements.

aphill70 commented 5 years ago

Yeah if I get some time I can poke