jenkinsci / nomad-plugin

Nomad cloud plugin for Jenkins
https://plugins.jenkins.io/nomad/
MIT License
56 stars 41 forks source link

Adding ACL Support and fixing a couple small bugs #48

Closed aphill70 closed 5 years ago

aphill70 commented 5 years ago

Found a small issue with the Name field created when we started requiring the post. The check doesn't work without changing the method on the field.

aphill70 commented 5 years ago

Addresses the following issues:

aphill70 commented 5 years ago

@peimanja This should work. I can't explicitly test the ACL support because of funky cert issues in my test environment but it saves and will add the appropriate header if provided and it doesn't break the current ACL less functionality

peimanja commented 5 years ago

@aphill70 Thank you man! I've built it and it works as expected.