search

jenkinsci / nomad-plugin

Nomad cloud plugin for Jenkins
https://plugins.jenkins.io/nomad/
MIT License
56 stars 41 forks source link

Remove nested NomadCloud object #55

Closed multani closed 5 years ago

multani commented 5 years ago

This should improve the interaction with the export feature of the "Configuration as code" plugin, which currently falls into an infinite loop:

  1. It starts to export a NomadCloud object.
  2. It then start to export each of the NomadSlaveTemplate objects ...
  3. Which in turn have a reference towards the NomadCloud object ...
  4. Which starts to get exported and loops back to 1.

Fix: #54 Fix: JENKINS-58491

@phedoreanu I replaced the embedded attribute by a new parameter injected where is needed. I'm not sure what's the "best" order for these arguments though, if you have a better idea on the topic, I'll gladly update that order.

multani commented 5 years ago

I've tested a new build on a local Jenkins instance and it seemed to work as before :+1:

multani commented 5 years ago

Works like a charm, thanks for the release @phedoreanu :+1: !