#67 add TLS support

[j3t]

• [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [x] Ensure that the pull request title represents the desired changelog entry
• [x] Please describe what you did
• [x] Link to relevant issues in GitHub or Jira
• [ ] Link to relevant pull requests, esp. upstream and downstream changes
• [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

I have added TLS support so that NomadServer which are secured by client/server certificates can used as well. corresponding Issue: https://github.com/jenkinsci/nomad-plugin/issues/67

[j3t]

Could please one of the maintainers review this PR? BTW, I cannot link the corresponding issue, could you please take care of that as well?

[multani]

Hi @j3t! Thanks a lot for the PR, I'll take a look in the coming days :wave:

[j3t]

Thanks @multani! I have added some more tests.

[j3t]

Hi @multani, that's great! Unfortunately, I don't have time this week to test it manually but it looks good to me what I have seen so far. So, I would say it's fine. 👍

[j3t]

Just a small adjusted so that NomadApiClientTLSTest is not failing on my local machine and a typo. I have also tested it manually against our Nomad environment. It is working as expected. 👍

[multani]

@j3t Awesome!

Let me merge this and prepare a new release just after that :+1: This is a fine addition to the plugin :heart:

[multani]

It's out in v0.8.0 :tada:

Note that's there some issues with Jenkins infrastructure at the moment, so I haven't been able to release it fully.

[multani]

It's now released, it should be available through the Update Center soon.