fix that the secret is not set when global security is disabled - Githubissues

jenkinsci / nomad-plugin

Nomad cloud plugin for Jenkins

https://plugins.jenkins.io/nomad/

MIT License

56 stars 41 forks source link

fix that the secret is not set when global security is disabled #92

Closed j3t closed 3 years ago

j3t commented 3 years ago

Fix that Agents in unsecured Jenkins environments can be started.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

How to reproduce?

start Jenkins with global security disabled (Configure Global Security -> Security Realm -> None)
install and setup the plugin as usual
create and start a job which starts an agent in Nomad
expected: agent is started
actual: agent is not started because the secret is empty