rockleez
commented
2 years ago @damianszczepanik on a similar not I've noticed that the proxy config only takes effect when the job config is opened and saved even with no changes being made. Is this normal behavior due to the architecture of Jenkins?
Example.
- I have Freestyle Job 1 and Pipeline Job 1 (with an additional step to send a message)
- Both jobs have the wehbook configured with some default notifications selected
- Running the jobs both work as expected and messages are sent to the teams channel
- Add proxy config
- Running the jobs again, the proxy config is not used except in Pipeline job 1 in the office365ConnectorSend message
- Open both jobs and click save without changing anything
- Config is now refreshed
-
- Running the jobs both work as expected and messages are sent to the teams channel this time via the proxy
damianszczepanik
Summary This PR addresses JENKINS-61989 and implements proxy support on the Office365ConnectorPlugin itself instead of utilizing the Jenkins global proxy config. In my case i would have to add multiple no proxy hosts to achieve the existing stability of the Jenkins server.
Implementation
Testing Unit Tests
Integration Tests
Tested using mvn:hpi run and also built a snapshot and deployed to a secondary local Jenkins running on linux
Created test jobs for pipeline and freestyle builds
Blocked incoming connections on the firewall
Used Fiddler Classic to act as a proxy and recorded traffic incoming via the proxy and messages appearing in MS Teams.
Regression testing confirmed that without the with the proxy not configured, the proxy configured in the pipeline, and the proxy configured globally, the plugin continues to function as expected.
Please roll this into a new release once approved