search

jenkinsci / office-365-connector-plugin

Office 365 Connector plugin sends jobs status notifications to Microsoft Teams or Outlook
https://plugins.jenkins.io/Office-365-Connector/
Apache License 2.0
89 stars 86 forks source link

Upgrade Mockito and PowerMock #286

Closed basil closed 2 years ago

basil commented 2 years ago

https://github.com/jenkinsci/office-365-connector-plugin/pull/284#discussion_r1012135631

CC @damianszczepanik

damianszczepanik commented 2 years ago

@basil this change breaks the build https://github.com/jenkinsci/office-365-connector-plugin/actions/runs/3414775475/jobs/5683222885

basil commented 2 years ago

@damianszczepanik No. This change had a green checkmark. The change that broke the build was your change in commit fa6f929, which added a Java 11 GitHub Actions run. PowerMock 2 does not support Java 11. Your commit that add Java 11 to the matrix introduced the problem, not mine.

damianszczepanik commented 2 years ago

Shame but... thanks for that.