jenkinsci / office-365-connector-plugin

Office 365 Connector plugin sends jobs status notifications to Microsoft Teams or Outlook
https://plugins.jenkins.io/Office-365-Connector/
Apache License 2.0
89 stars 86 forks source link

Accept more HTTP response codes #357

Closed nosnilmot closed 4 months ago

nosnilmot commented 4 months ago

Only consider HTTP response codes >= 400 as errors, avoiding unnecessary retries and potential duplicates

Fixes #356

Note: this is NOT a full fix for Microsoft's deprecation of Office 365 connectors for Teams, but is sufficient to allow use of powerautomation workflow to adapt the existing message content.

Testing done

it compiles and passes existing unit tests

Submitter checklist

damianszczepanik commented 4 months ago

New version is release, you can update and check

nosnilmot commented 4 months ago

New version is release, you can update and check

The latest version offered by Jenkins is still 4.21.1 (in https://updates.jenkins.io/current/update-center.json), is there another step necessary to make 4.21.2 generally available?

damianszczepanik commented 4 months ago

You are right and thanks for letting me know. I see another plugin has same problem - SNAPSHOT version is published instead of final one. New version should be available soon as is hopefully correctly deployed https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/Office-365-Connector/4.21.5/ and the reason of invalid version was this commit https://github.com/jenkinsci/office-365-connector-plugin/commit/6ee69d944807886802671f0ef5424a3bc991c6bc that introduces double SNAPSHOT - still don't know why as the release process did not change but the dependencies were updated