search

jenkinsci / office-365-connector-plugin

Office 365 Connector plugin sends jobs status notifications to Microsoft Teams or Outlook
https://plugins.jenkins.io/Office-365-Connector/
Apache License 2.0
89 stars 86 forks source link

Add switch to enable "AlwaysIncludeBuildUrl" #361

Closed 96LLeGend closed 3 months ago

96LLeGend commented 3 months ago

What feature do you want to see added?

Since PR#272, when the build is completed, the url to the build only available if the build is not success. Can we make it configurable?

It should be a easy change, just add new flags to the Webhook object and the StepParameters object.

Then just pass the flag in and check it in createCompletedCard

Upstream changes

No response

Are you interested in contributing this feature?

I am kind of new to Java project and I am not sure how to build and test this project locally. If there are not strong opposition and if someone can give me some tips on how to set up the environment, I will be more than happy to give it a shot🙂

96LLeGend commented 3 months ago

After a bit of digging, I found that you can add ${BUILD_URL} as one of your Fact Definitions then you will always have the link, so I don't see any point to develop this in the backdrop of switching over to Microsoft Workflows