Closed jglick closed 5 months ago
Attention: Patch coverage is 75.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 73.15%. Comparing base (
e327bf2
) to head (db811f2
). Report is 25 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...ava/org/jenkinsci/plugins/oic/OicUserProperty.java | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If you log in with OIDC with a groups field defined, then go to your user config page and create an API token, then use that API token to run the CLI command
who-am-i
, your groups are listed as expected. But if you then Save the same page and try the CLI command again, you are shown as having no groups. This is because saving the page wiped out theOicUserProperty
. AFAICT this has been broken since #12. The corrected idiom can be seen inLastGrantedAuthoritiesProperty
in core, a very similar property. Actually we could probably use that instead ofOicUserProperty
by merely callingSecurityListener.fireLoggedIn
; I did not try that yet.