search

jenkinsci / oic-auth-plugin

A Jenkins plugin which lets you login to Jenkins using your own, self-hosted or public openid connect server.
https://plugins.jenkins.io/oic-auth
MIT License
74 stars 94 forks source link

Replace `OicUserProperty` with `LastGrantedAuthoritiesProperty` #333

Closed jglick closed 5 months ago

jglick commented 5 months ago

More radical simplification of #332.

michael-doubez commented 5 months ago

@jglick sorry, I didn't realize #332 and #333 would conflict. Can you please resolve conflicts ? (from what I see, removal of user properties and adaptation in PluginTest)

jglick commented 5 months ago

I guess you rebase-merged, which confuses Git. Fixing.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.46%. Comparing base (e327bf2) to head (bca3705). Report is 27 commits behind head on master.

Files Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 21.05% 14 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #333 +/- ## ============================================ - Coverage 73.35% 72.46% -0.89% + Complexity 211 201 -10 ============================================ Files 10 9 -1 Lines 882 839 -43 Branches 124 119 -5 ============================================ - Hits 647 608 -39 + Misses 172 170 -2 + Partials 63 61 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

michael-doubez commented 5 months ago

Many thanks

basil commented 2 months ago

Causes #391