Closed Vlatombe closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.02%. Comparing base (
bca3705
) to head (b7205f1
). Report is 14 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In a CloudBees CI HA setup, I recently upgraded to 4.297.vcddb_d8a_e4694 (including #310). The various changes to
OicSecurityRealm
broke serialization due to usage of an anonymous inner class (extendingOicSession
) that gets stored in session.Storing
OicSession
in session is actually only required for a brief amount of time, only betweendoCommenceLogin
anddoFinishLogin
. Once the user is logged in, it is no longer necessary to store the whole object. The only thing that needs to be persisted is the state, as it gets used later for logging out.Testing done
Submitter checklist