Closed mprausa closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.44%. Comparing base (
b7205f1
) to head (8e99549
). Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've added a second commit. I think the other change on the same line done in PR #357 is incorrect as well. We have to subtract allowedClockSkewFixed
, so that the token is refreshed earlier not later.
@michael-doubez Yes, I agree. I've removed the second commit.
currentTimestamp
is in millis already which is why it should not be mulitplied by 1000.The constructor of
OicCredentials
is called withCLOCK.millis()
(here and here) for thecurrentTimestamp
parameter which shows thatcurrentTimestamp
is indeed in millis and not seconds.This bug was introduced in bba32e09 (PR #357).
Testing done
Submitter checklist