search

jenkinsci / oic-auth-plugin

A Jenkins plugin which lets you login to Jenkins using your own, self-hosted or public openid connect server.
https://plugins.jenkins.io/oic-auth
MIT License
71 stars 88 forks source link

code coverage (codecov) on PRs is broken #369

Open jtnord opened 1 month ago

jtnord commented 1 month ago

Jenkins and plugins versions report

Per https://github.com/jenkinsci/oic-auth-plugin/pull/368#issuecomment-2291264497 and https://github.com/jenkinsci/oic-auth-plugin/pull/368#issuecomment-2291294019 the code coverage checks are using an obsolete baseline leading to changes in other PRs being included in reports for new PRs.

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

Take a look at the coverage report for https://github.com/jenkinsci/oic-auth-plugin/pull/368 and observe the base commit is not the correct base commit.

https://app.codecov.io/gh/jenkinsci/oic-auth-plugin shows latest commit b7205f1 which is not the latest commit on master

upload job for master should succeed but is failing due to a lack of token.

Expected Results

code coverage is computed against the correct base for a plugin latest known commit for code coverage on https://app.codecov.io/gh/jenkinsci/oic-auth-plugin matches the latest commit on master (subject to any delay in building the job which should be < 1 hr)

Actual Results

baseline is old code coverage is being calculated against this old delta

Anything else?

No response

Are you interested in contributing a fix?

No response

michael-doubez commented 2 weeks ago

It seems it stopped working 1 month ago. I'll have a look

michael-doubez commented 2 weeks ago

Waiting for https://github.com/jenkins-infra/helpdesk/issues/4267