jenkinsci / oic-auth-plugin

A Jenkins plugin which lets you login to Jenkins using your own, self-hosted or public openid connect server.
https://plugins.jenkins.io/oic-auth
MIT License
71 stars 88 forks source link

Make hashcode test really useful #373

Closed Vlatombe closed 2 weeks ago

Vlatombe commented 3 weeks ago

The hashcode test is not testing much really. It is more efficient to check all fields and check whether they change the hashcode.

In the process, I saw that one of the fields (tokenAuthMethods) was missing from the hashCode method computation.

Testing done

Submitter checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.44%. Comparing base (b7205f1) to head (46e8cd8). Report is 18 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #373 +/- ## ============================================ - Coverage 72.02% 71.44% -0.58% + Complexity 234 232 -2 ============================================ Files 11 11 Lines 990 991 +1 Branches 142 142 ============================================ - Hits 713 708 -5 - Misses 199 205 +6 Partials 78 78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.