Required environment variable matching for claim precedence

iwarapter commented 1 year ago

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

As part of #22 I have had a (very rough) go at supporting required environment variables for claims.

I have outstanding issue on tests with missing descriptor java.lang.AssertionError: class java.lang.String is missing its descriptor in public final java.util.List io.jenkins.plugins.oidc_provider.config.ClaimTemplate.requiredEnvVars. See https://www.jenkins.io/redirect/developer/class-is-missing-descriptor not sure how to solve this for List of String.

jglick commented 1 year ago

Thanks! I am pretty busy so I cannot promise to review this promptly but I will get to it when I can.

jglick commented 1 year ago

Still have not had time to review I am afraid—too many things to juggle!

iwarapter commented 1 year ago

hey @jglick, wondering if you had a chance to look at this?

jglick commented 1 year ago

Not yet I am afraid.

LeoQuote commented 8 months ago

@iwarapter hi, I encountered similar issue with you, I tried a different path which is now working ! Try #35 with the prebuilt hpi package: https://ci.jenkins.io/job/Plugins/job/oidc-provider-plugin/job/PR-35/

jenkinsci / oidc-provider-plugin

Required environment variable matching for claim precedence #23