Getting documents from 1pass via plugin only gets 1st line from document

simonqbz commented 7 months ago

Jenkins and plugins versions report

Environment

```Jenkins: 2.426.2 OS: Linux - 6.1.58+ Java: 17.0.9 - Eclipse Adoptium (OpenJDK 64-Bit Server VM) --- apache-httpcomponents-client-4-api:4.5.14-208.v438351942757 authentication-tokens:1.53.v1c90fd9191a_b_ blueocean:1.27.9 blueocean-autofavorite:1.2.5 blueocean-bitbucket-pipeline:1.27.9 blueocean-commons:1.27.9 blueocean-config:1.27.9 blueocean-core-js:1.27.9 blueocean-dashboard:1.27.9 blueocean-display-url:2.4.2 blueocean-events:1.27.9 blueocean-git-pipeline:1.27.9 blueocean-github-pipeline:1.27.9 blueocean-i18n:1.27.9 blueocean-jwt:1.27.9 blueocean-personalization:1.27.9 blueocean-pipeline-api-impl:1.27.9 blueocean-pipeline-editor:1.27.9 blueocean-pipeline-scm-api:1.27.9 blueocean-rest:1.27.9 blueocean-rest-impl:1.27.9 blueocean-web:1.27.9 bootstrap5-api:5.3.2-3 bouncycastle-api:2.30.1.77-225.v26ea_c9455fd9 branch-api:2.1135.v8de8e7899051 caffeine-api:3.1.8-133.v17b_1ff2e0599 checks-api:2.0.2 cloudbees-bitbucket-branch-source:856.v04c46c86f911 cloudbees-folder:6.858.v898218f3609d command-launcher:107.v773860566e2e commons-httpclient3-api:3.1-3 commons-lang3-api:3.13.0-62.v7d18e55f51e2 commons-text-api:1.11.0-95.v22a_d30ee5d36 credentials:1311.vcf0a_900b_37c2 credentials-binding:642.v737c34dea_6c2 dark-theme:404.v3a_7fdced40f9 display-url-api:2.200.vb_9327d658781 durable-task:523.va_a_22cf15d5e0 echarts-api:5.4.3-2 extended-choice-parameter:376.v2e02857547b_a_ favorite:2.208.v91d65b_7792a_c font-awesome-api:6.5.1-1 git:5.2.1 git-client:4.6.0 git-parameter:0.9.19 git-server:99.va_0826a_b_cdfa_d github:1.37.3.1 github-api:1.318-461.v7a_c09c9fa_d63 github-branch-source:1767.va_7d01ea_c7256 google-compute-engine:4.556.v061a_dee4ec34 google-login:1.8 google-oauth-plugin:1.328.v6ea_0fb_df5f7b_ handy-uri-templates-2-api:2.1.8-30.v7e777411b_148 htmlpublisher:1.32 instance-identity:185.v303dc7c645f9 ionicons-api:56.v1b_1c8c49374e jackson2-api:2.15.3-372.v309620682326 jakarta-activation-api:2.0.1-3 jakarta-mail-api:2.0.1-3 javax-activation-api:1.2.0-6 javax-mail-api:1.6.2-9 jaxb:2.3.9-1 jdk-tool:73.vddf737284550 jenkins-design-language:1.27.9 jersey2-api:2.41-133.va_03323b_a_1396 jira:3.12 jjwt-api:0.11.5-77.v646c772fddb_0 joda-time-api:2.12.5-5.v5495a_235fedf jquery3-api:3.7.1-1 jsch:0.2.8-65.v052c39de79b_2 json-path-api:2.8.0-5.v07cb_a_1ca_738c junit:1252.vfc2e5efa_294f mailer:463.vedf8358e006b_ mapdb-api:1.0.9-28.vf251ce40855d matrix-auth:3.2.1 matrix-project:818.v7eb_e657db_924 mina-sshd-api-common:2.11.0-86.v836f585d47fa_ mina-sshd-api-core:2.11.0-86.v836f585d47fa_ miniorange-saml-sp:2.4.1 oauth-credentials:0.646.v02b_66dc03d2e okhttp-api:4.11.0-157.v6852a_a_fa_ec11 onepassword-secrets:1.0.0 pipeline-build-step:540.vb_e8849e1a_b_d8 pipeline-graph-analysis:202.va_d268e64deb_3 pipeline-groovy-lib:689.veec561a_dee13 pipeline-input-step:477.v339683a_8d55e pipeline-milestone-step:111.v449306f708b_7 pipeline-model-api:2.2151.ve32c9d209a_3f pipeline-model-definition:2.2151.ve32c9d209a_3f pipeline-model-extensions:2.2151.ve32c9d209a_3f pipeline-rest-api:2.34 pipeline-stage-step:305.ve96d0205c1c6 pipeline-stage-tags-metadata:2.2151.ve32c9d209a_3f pipeline-stage-view:2.34 pipeline-utility-steps:2.16.0 plain-credentials:143.v1b_df8b_d3b_e48 plugin-util-api:3.6.0 pubsub-light:1.18 role-strategy:689.v731678c3e0eb_ scm-api:683.vb_16722fb_b_80b_ script-security:1294.v99333c047434 slack:684.v833089650554 snakeyaml-api:2.2-111.vc6598e30cc65 sse-gateway:1.26 ssh-credentials:308.ve4497b_ccd8f4 sshd:3.312.v1c601b_c83b_0e structs:325.vcb_307d2a_2782 subversion:2.17.3 theme-manager:215.vc1ff18d67920 token-macro:400.v35420b_922dcb_ trilead-api:2.84.v72119de229b_7 variant:60.v7290fc0eb_b_cd workflow-api:1283.v99c10937efcb_ workflow-basic-steps:1042.ve7b_140c4a_e0c workflow-cps:3826.v3b_5707fe44da_ workflow-durable-task-step:1313.vcb_970b_d2a_fb_3 workflow-job:1385.vb_58b_86ea_fff1 workflow-multibranch:756.v891d88f2cd46 workflow-scm-step:415.v434365564324 workflow-step-api:639.v6eca_cd8c04a_a_ workflow-support:865.v43e78cc44e0d ```

What Operating System are you using (both controller, and any agents involved in the problem)?

Controller : jenkins/jenkins:lts-jdk17 docker container Nodes: ubuntu-2204-jammy-v20231213a

Reproduction steps

Create multiline document in 1pass
Read the document using op CLI and see that it works:

op read "op://Jenkins/testDoc/multilinedoc.txt"
This is
a multiline
document
1
2
3

Now try to get same document via the plugin in a jenkins pipeline:

def secrets = [
    [envVar: 'testDoc', secretRef: 'op://Jenkins/testDoc/multilinedoc.txt']
]
pipeline {
    agent {
        label "devops"
    }
    stages {
        stage('Get document from 1pass') {
            steps {
                withSecrets (secrets: secrets) {
                    sh 'echo $testDoc >testDoc.txt'
                } 
            }
        }
    }
}

The testDoc.txt now contains only the 1st line of the document:

xyz@jenkins-node-devops-f05mwt:/tmp/workspace/test-1pass$ cat testDoc.txt
This is
xyz@jenkins-node-devops-f05mwt:/tmp/workspace/test-1pass$

Expected Results

Expected result is to get the whole document

Actual Results

Actual result is only the 1st line of the document

Anything else?

No response

Are you interested in contributing a fix?

No response

Ademord commented 4 months ago

I have the same requirement / same issue, and would highly appreciate some update on this ❤️‍🔥

simonqbz commented 2 months ago

Maybe stupid question, but in Jenkins I only see release 1.0.0 available. When will this fix be released so it can be updated in Jenkins plugin?

edif2008 commented 2 months ago

We will release it very soon and we will let you know when the release is out.

edif2008 commented 1 month ago

Hey @simonqbz!

Good news! We've just released version 1.0.2 which contains the fix for this bug. 🎉

jenkinsci / onepassword-secrets-plugin