This PR adds two parameters to the global config of the plugin.
With these parameters it's possible to set additional options added to the processes started in the onMonit step.
These are global defaults and can be overridden by setting the corresponding parameters in the step.
This fixes #22.
What is not covered of #22 in this PR are the overriding of the otel config template per onMonit step and overriding some parts of this config file. That would require a yaml object merge and is too complex for this PR.
Testing done
I manually installed the plugin in a local test Jenkins instance and verified that a pipeline execution of the onMonit step used the correct process arguments using the following test cases:
no additional options set (both global config and step) → no additional option set when starting the process
default additional option set in global config → used this additional option
additional option set in step, no global config default → used this additional option
additional option set both in global config and in step → used the additional option of the step parameter (not the global default)
I did this once for node_exporter and once for otel-contrib to also verify the parameters correspond to the correct process.
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
This PR adds two parameters to the global config of the plugin.
With these parameters it's possible to set additional options added to the processes started in the onMonit step. These are global defaults and can be overridden by setting the corresponding parameters in the step.
This fixes #22.
What is not covered of #22 in this PR are the overriding of the otel config template per onMonit step and overriding some parts of this config file. That would require a yaml object merge and is too complex for this PR.
Testing done
I manually installed the plugin in a local test Jenkins instance and verified that a pipeline execution of the onMonit step used the correct process arguments using the following test cases:
I did this once for node_exporter and once for otel-contrib to also verify the parameters correspond to the correct process.