jenkinsci / opentelemetry-plugin

Monitor and observe Jenkins with OpenTelemetry.
https://plugins.jenkins.io/opentelemetry/
Apache License 2.0
93 stars 47 forks source link

fix: parameters URL encode #822

Closed kuisathaverat closed 3 months ago

kuisathaverat commented 3 months ago

Testing done

The parameters passed to the URL are not correctly URL encoded. This causes an error in the parser Jenkins uses to display the link. This PR changes the implementation to use the org.apache.commons.codec.net.URLCodec to perform the URL encoding.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

closes https://github.com/jenkinsci/opentelemetry-plugin/issues/821