search

jenkinsci / packaging

Native packaging for Jenkins
https://jenkins.io
42 stars 83 forks source link

Automated testing #225

Closed basil closed 2 years ago

basil commented 2 years ago

What feature do you want to see added?

This repository lacks a Jenkinsfile or any CI/CD. This makes it all too easy for regressions to be introduced. As a result, this repository resists change. In order to move forward with critical modernization efforts such as systemd(1) support, a prerequisite task is adding test coverage to this repository. Once there is test coverage, we will be able to make major changes with confidence that we are not introducing regressions.

Upstream changes

No response

basil commented 2 years ago

Some "fat" images:

Some test orchestrators:

Some test verifiers:

basil commented 2 years ago

As of today automated testing has been added for:

timja commented 2 years ago

Any reason to keep this open?

basil commented 2 years ago

I think I'd like to see a little deeper coverage in test cases before declaring victory on this issue. The platform matrix is now reasonably broad, but the test coverage is still quite thin. While I don't think we need to implement all test cases that have been enumerated right away, I think we should add a few more in the short term than just a basic smoke test.

basil commented 2 years ago

Now that we do some basic testing that the Java process is running and that its PID matches the one in the PID file, I'm going to declare victory on this task.