search

jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 13 forks source link

Histogram label undefined #118

Closed mawHBT closed 2 years ago

mawHBT commented 2 years ago

What feature do you want to see added?

Histogramm label under "Inspect measurements" shows "undefined".

Unbenannt

Upstream changes

No response

DaGeRe commented 2 years ago

Thanks for the hint. For measurement overview and rca measurement overview, the top left card is empty, since this is the overview histogram and in this cases, we are already at the overview. This is not nice for the end user, since this is knowledge which is not documented.

For measurement, I completely removed it. For RCA overview, this is not easily possible, since it is the Javascript that decides whether we are in overview or node measurement, but the backend which decides whether a div is present. I'll try to fully fix this.

The current changes are available with https://github.com/jenkinsci/peass-ci-plugin/commit/7c23aecb135c46e537212e9d9dc6df1e096ae95c

DaGeRe commented 2 years ago

The div is now completely hidden and the layout is fixed: https://github.com/jenkinsci/peass-ci-plugin/commit/21fb27cc09e402873579e7162e223882ee93cb38 Does this work for you?

mawHBT commented 2 years ago

Looks fine now.