jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 12 forks source link

Include/Exclude by Rule #150

Closed Schattensilber closed 2 years ago

Schattensilber commented 2 years ago

What feature do you want to see added?

We have two types of tests: Simple Unit Tests: Just java Module Tests: java + test db (based on docker)

They would benefit from very different configurations, i.e. the second kind is measureWorkloadOnly, whereas the first can utilize repetitions.

I'd set up two different pipelines for them, but the include/exclude by name config is not powerful enough. Much better would be to differentiate based on the ClassRule DockerRule.

Ideally there could be some --include-by-rule='DockerRule' or similar functionality.

Upstream changes

No response

DaGeRe commented 2 years ago

Therefore, three tasks need to be executed:

DaGeRe commented 2 years ago

The first task is implemented by https://github.com/DaGeRe/peass/commit/8495b1d45d0fc7d692be345ddc85694bc81afa32

DaGeRe commented 2 years ago

The second task is implemented since https://github.com/DaGeRe/peass/commit/2746095c2ebfcf611fb6ad0a17d1aa312640efe2

DaGeRe commented 2 years ago

The third task is finished by https://github.com/jenkinsci/peass-ci-plugin/commit/c7f78410f1dfcb3677dc172c111a208ac59ab996, now, the feature should work overall. Can you confirm this @Schattensilber ?

Schattensilber commented 2 years ago

I'll test and close if it works

DaGeRe commented 2 years ago

Another bugfix was necessary, since https://github.com/DaGeRe/peass/commit/597117154e9a13917e1253882a99a148f32cf0e9 this should work now.