search

jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 12 forks source link

Deal with not-any-more compiling predecessor version #181

Closed Schattensilber closed 1 year ago

Schattensilber commented 2 years ago

What feature do you want to see added?

A possible situation that we have come across sometimes is such:

Version A compiles, and at time of internal publishing version B and C compile, but use snapshot dependencies. When version D is published the snapshot dependencies are overwritten, so B and C do not compile any more.

Then peass-ci will continue to try and build/measure against C with continuing fails.

One possible solution is to search the predecessor versions backwards for the newest older version that compiles, so in the example to test B and then A and build against A. This might fail, if for some reason all older builds cannot compile any more, but it would give the best coverage.

Upstream changes

No response

DaGeRe commented 2 years ago

This should work starting with https://github.com/DaGeRe/peass/commit/64551638eed46deeb0d82071f392dcde36853524, can you confirm this?

DaGeRe commented 1 year ago

Since there is no activity here, I assume this works now. Feel free to re-open if not.