search

jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 13 forks source link

Add parameter for setting a maximum file-size for log-files read by jenkins #182

Closed mawHBT closed 2 years ago

mawHBT commented 2 years ago

What feature do you want to see added?

If a build creates very big logs, reading of build.xml by jenkins after the job has finished can cause an OOM-error. To prevent this, a parameter is needed for setting a maximum file-size. If build.xml is bigger than the maximum, jenkins should not try to read it. So the file still exists for further examination but does not cause the oom-error if read by jenkins.

Upstream changes

No response

DaGeRe commented 2 years ago

This should work starting with https://github.com/jenkinsci/peass-ci-plugin/commit/57bde495a09603a683788acad53d61902ecadc91, can you confirm this?

mawHBT commented 2 years ago

This is working now. If logsize is bigger than importLogSizeInMb they aren't loaded and you get a message instead.

DaGeRe commented 2 years ago

Thanks for the feedback, if things are ready, you can also close the issue ;)