search

jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 12 forks source link

Also add aspectJ library, if (integration)test-block in build.gradle is empty #202

Closed mawHBT closed 1 year ago

mawHBT commented 2 years ago

What feature do you want to see added?

If you set onlyOneCallRecording, kieker-xxx-aspectj.jar has to be added to jvmArgs in build.gradle. This does not work, if no (integration)test-block is present.

Upstream changes

No response

mawHBT commented 2 years ago

As a firs step, I added a test for checking if aspectJ-library is added to jvmArgs if no test-block is present in PR #101. This currently fails.

mawHBT commented 2 years ago

TestJVMArgsGradle was green, but testing with a HBT-project failed. The appropriate modules had test- and integrationTest-tasks but no appropriate blocks with any configurations. jvmArgs were added, systemProperties inside it, but no aspectJ-line (which should because of onlyOneCallRecording). Unfortunately I was not able to provide a test to reproduce this. But with PR#105 this now works also. I checked build.gradle of the modules for different combinations of (empty/not present)(IT)test-blocks and jvmArgs set or not.

mawHBT commented 2 years ago

Since some tests where added and this was also checked "by hand" for several combinations of (empty/not present)(IT)test-blocks and jvmArgs, we could close this, right?

DaGeRe commented 2 years ago

Yes, this can be closed from my point of view.