search

jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 12 forks source link

Delete directory before copying, so error that occurs with Jenkins agents on some setups is avoided #203

Closed malice00 closed 2 years ago

malice00 commented 2 years ago

This is a rebase of the branch 'debugCopyFromRemote' that was created for us after contact by mail.

We rebased the branch to test the changes on the latest release of the plugin, to make sure they worked the same as on the version it was originally branched from.

The branch fixes problems we had when the plugin is copying its data from the remote agent back to the controller, which includes the GIT repository that has several files configured as read-only. After the initial copying, this part of the code would throw exceptions when trying to overwrite these files on the controller.

We did try to make the copying work in other ways (eg exclude the repo), but this then had other negative effects on the code, so we decided to stick with the original change.

malice00 commented 2 years ago

Don't know why this is failing, someone please take a look and restart the build...

DaGeRe commented 2 years ago

Sorry for the late reply, I currently do not get mails on PRs (since the repository belongs to jenkinsci - I need to figure out how to fix this).

Thanks for the PR. Please always create PRs against develop, since new features should be tested on develop until they are merged.

For this PR, I just cherry-picked the commit: https://github.com/jenkinsci/peass-ci-plugin/commit/7c24f91d7488751f604084f6432fab24b038e6c6 I hope this works for you - if not, feel free to add an issue or to create another PR.

malice00 commented 1 year ago

Sorry, my bad! I'll make a build of 'develop', test it and let you know if it still works as expected.