search

jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 13 forks source link

Fix Unit of Measurement Values #84

Closed DaGeRe closed 2 years ago

DaGeRe commented 2 years ago

What feature do you want to see added?

Measurement values are currently displayed as as microseconds (https://github.com/jenkinsci/peass-ci-plugin/blob/18793792f9043b3d90d05d830e5e0fe428873a8f/src/main/resources/de/dagere/peass/ci/MeasureVersionAction/index.jelly#L111) or as micro- or nanoseconds depending on the value (https://github.com/jenkinsci/peass-ci-plugin/blob/18793792f9043b3d90d05d830e5e0fe428873a8f/src/main/resources/de/dagere/peass/ci/MeasureVersionAction/measurements.jelly#L55).

For values bigger than microseconds, i.e. milliseconds or seconds, this does not make sense. Therefore, it would be nice if a method for providing the measurements in a suitable unit could be added.

Upstream changes

No response

mawHBT commented 2 years ago

This works for MeasureVersionAction but has to be implemented in all the other places where measurement values are displayed, e.g. under "Inspect Node" and "Inspect Measurement".