jenkinsci / peass-ci-plugin

Jenkins plugin for peass to support performance measurement in CI
https://plugins.jenkins.io/peass-ci/
GNU Affero General Public License v3.0
4 stars 13 forks source link

ParameterizedTest #95

Closed bam-hbt closed 2 years ago

bam-hbt commented 2 years ago

What feature do you want to see added?

Peass doesn’t work with ParameterizedTest

Upstream changes

No response

DaGeRe commented 2 years ago

Thanks for the issue. This requires the following adaptions:

Unfortunately, test selection does currently not really work, neither in Maven nor in Gradle. I filed issues in the corresponding issue trackers: https://issues.apache.org/jira/browse/SUREFIRE-2010 and https://github.com/gradle/gradle/issues/19897. Unforunately, if this is not solved, we can not proceed for JUnit 5 and Gradle (which is, I assume, the main configuration you are interested in).

DaGeRe commented 2 years ago

This should now be finished. Unfortunately, the test selectors in maven and gradle do not work for JUnit 5. Therefore, I implemented a workaround: KoPeMe checks now by the KOPEME_CHOSEN_PARAMETER_INDEX environment variable, which index of a parameterized test should be run (https://github.com/DaGeRe/KoPeMe/blob/d7711543dc45bb1bf08f8c72e0b69512e84bcefd/kopeme-junit/src/main/java/de/dagere/kopeme/junit/rule/KoPeMeStandardRuleStatement.java#L99). This should work now in both Maven and Gradle and both JUnit 4 and 5.

Can you confirm this?

bam-hbt commented 2 years ago

Thanks for the Fix. This works now.