search

jenkinsci / persistent-parameter-plugin

https://plugins.jenkins.io/persistent-parameter/
MIT License
7 stars 11 forks source link

When anonymous access is disabled on Jenkins, the plugin does not work with the build trigger Poll CMS (pipeline) #15

Open aleksandr-barykov opened 1 year ago

aleksandr-barykov commented 1 year ago

Jenkins and plugins versions report

Environment Jenkins: 2.375.1 OS: Linux - 3.10.0-1160.2.2.el7.x86_64 --- Office-365-Connector:4.18.0 ace-editor:1.1 active-directory:2.29 analysis-model-api:10.21.0 ansible:1.1 ansicolor:1.0.2 ant:481.v7b_09e538fcca antisamy-markup-formatter:155.v795fb_8702324 apache-httpcomponents-client-4-api:4.5.13-138.v4e7d9a_7b_a_e61 authentication-tokens:1.4 authorize-project:1.4.0 badge:1.9.1 blueocean:1.26.0 blueocean-autofavorite:1.2.5 blueocean-bitbucket-pipeline:1.26.0 blueocean-commons:1.26.0 blueocean-config:1.26.0 blueocean-core-js:1.26.0 blueocean-dashboard:1.26.0 blueocean-display-url:2.4.1 blueocean-events:1.26.0 blueocean-git-pipeline:1.26.0 blueocean-github-pipeline:1.26.0 blueocean-i18n:1.26.0 blueocean-jira:1.26.0 blueocean-jwt:1.26.0 blueocean-personalization:1.26.0 blueocean-pipeline-api-impl:1.26.0 blueocean-pipeline-editor:1.26.0 blueocean-pipeline-scm-api:1.26.0 blueocean-rest:1.26.0 blueocean-rest-impl:1.26.0 blueocean-web:1.26.0 bootstrap4-api:4.6.0-5 bootstrap5-api:5.2.1-3 bouncycastle-api:2.26 branch-api:2.1051.v9985666b_f6cc build-blocker-plugin:1.7.8 build-environment:1.7 build-timeout:1.25 built-on-column:1.3 caffeine-api:2.9.3-65.v6a_47d0f4d1fe checks-api:1.8.1 cloudbees-bitbucket-branch-source:791.vb_eea_a_476405b cloudbees-folder:6.800.v71307ca_b_986b cobertura:1.17 code-coverage-api:3.4.1 command-launcher:90.v669d7ccb_7c31 commons-httpclient3-api:3.1-3 commons-lang3-api:3.12.0-36.vd97de6465d5b_ commons-text-api:1.10.0-27.vb_fa_3896786a_7 conditional-buildstep:1.4.2 convert-to-pipeline:1.0 cppcheck:1.26 credentials:1214.v1de940103927 credentials-binding:523.vd859a_4b_122e6 cucumber-reports:5.7.4 data-tables-api:1.12.1-4 display-url-api:2.3.7 docker-commons:1.21 docker-java-api:3.2.13-37.vf3411c9828b9 docker-plugin:1.2.10 docker-workflow:563.vd5d2e5c4007f downstream-buildview:69.v16da_b_2c36f6c dtkit-api:3.0.2 durable-task:503.v57154d18d478 echarts-api:5.4.0-1 email-ext:2.92 envinject:2.892.v25453b_80e595 envinject-api:1.199.v3ce31253ed13 external-monitor-job:203.v683c09d993b_9 favorite:2.4.1 font-awesome-api:6.2.1-1 forensics-api:1.17.0 git:4.14.3 git-client:3.13.1 git-parameter:0.9.18 git-server:99.va_0826a_b_cdfa_d git-tag-message:1.7.1 github:1.36.0 github-api:1.303-400.v35c2d8258028 github-branch-source:1696.v3a_7603564d04 gitlab-api:5.0.1-78.v47a_45b_9f78b_7 gitlab-plugin:1.6.0 gradle:2.2 groovy-postbuild:2.5 handlebars:3.0.8 handy-uri-templates-2-api:2.1.8-22.v77d5b_75e6953 htmlpublisher:1.31 instance-identity:142.v04572ca_5b_265 ionicons-api:31.v4757b_6987003 jackson2-api:2.14.1-313.v504cdd45c18b jakarta-activation-api:2.0.1-2 jakarta-mail-api:2.0.1-2 javadoc:226.v71211feb_e7e9 javax-activation-api:1.2.0-5 javax-mail-api:1.6.2-8 jaxb:2.3.7-1 jdk-tool:63.v62d2fd4b_4793 jenkins-design-language:1.26.0 jersey2-api:2.37-1 jira:3.8 jjwt-api:0.11.5-77.v646c772fddb_0 jobConfigHistory:1191.v168c8c2b_956a jquery:1.12.4-1 jquery-detached:1.2.1 jquery3-api:3.6.1-2 jsch:0.1.55.61.va_e9ee26616e7 junit:1166.va_436e268e972 ldap:2.12 locale:226.v008e1b_58cb_b_0 lockable-resources:1102.vde5663d777cf mailer:438.v02c7f0a_12fa_4 mapdb-api:1.0.9-28.vf251ce40855d matrix-auth:3.1.6 matrix-project:785.v06b_7f47b_c631 matrix-reloaded:1.1.3 maven-plugin:3.20 mercurial:1260.vdfb_723cdcc81 metrics:4.2.13-420.vea_2f17932dd6 mina-sshd-api-common:2.9.2-50.va_0e1f42659a_a mina-sshd-api-core:2.9.2-50.va_0e1f42659a_a momentjs:1.1.1 mstest:1.0.0 next-build-number:1.8 nexus-artifact-uploader:2.14 nodelabelparameter:1.11.0 okhttp-api:4.9.3-108.v0feda04578cf pam-auth:1.10 parameterized-trigger:2.45 permissive-script-security:0.7 persistent-parameter:1.3 pipeline-build-step:2.18 pipeline-github-lib:38.v445716ea_edda_ pipeline-graph-analysis:195.v5812d95a_a_2f9 pipeline-groovy-lib:629.vb_5627b_ee2104 pipeline-input-step:466.v6d0a_5df34f81 pipeline-milestone-step:101.vd572fef9d926 pipeline-model-api:2.2118.v31fd5b_9944b_5 pipeline-model-definition:2.2118.v31fd5b_9944b_5 pipeline-model-extensions:2.2118.v31fd5b_9944b_5 pipeline-rest-api:2.28 pipeline-stage-step:296.v5f6908f017a_5 pipeline-stage-tags-metadata:2.2118.v31fd5b_9944b_5 pipeline-stage-view:2.28 pipeline-utility-steps:2.14.0 plain-credentials:139.ved2b_9cf7587b plugin-util-api:2.20.0 popper-api:1.16.1-3 popper2-api:2.11.6-2 postbuild-task:1.9 powershell:1.7 preSCMbuildstep:44.v6ef4fd97f56e prism-api:1.29.0-2 progress-bar-column-plugin:1.0 prometheus:2.0.11 publish-over:0.22 publish-over-cifs:0.16 pubsub-light:1.17 pvs-studio:7.07 python:1.3 rebuild:1.34 resource-disposer:0.20 rich-text-publisher-plugin:1.4 role-strategy:569.v7476f8e4fe29 run-condition:1.5 scm-api:631.v9143df5b_e4a_a script-security:1228.vd93135a_2fb_25 snakeyaml-api:1.33-90.v80dcb_3814d35 sse-gateway:1.26 ssh-credentials:305.v8f4381501156 ssh-slaves:2.854.v7fd446b_337c9 ssh-steps:2.0.39.v831c5e6468b_c sshd:3.275.v9e17c10f2571 structs:324.va_f5d6774f3a_d subversion:2.16.0 timestamper:1.21 token-macro:321.vd7cc1f2a_52c8 trilead-api:2.84.v72119de229b_7 valgrind:0.28 variant:59.vf075fe829ccb view-job-filters:2.3 warnings-ng:9.22.0 windows-slaves:1.8.1 workflow-aggregator:590.v6a_d052e5a_a_b_5 workflow-api:1200.v8005c684b_a_c6 workflow-basic-steps:994.vd57e3ca_46d24 workflow-cps:3583.v4f58de0d78d5 workflow-durable-task-step:1217.v38306d8fa_b_5c workflow-job:1254.v3f64639b_11dd workflow-multibranch:716.vc692a_e52371b_ workflow-remote-loader:1.5 workflow-scm-step:400.v6b_89a_1317c9a_ workflow-step-api:639.v6eca_cd8c04a_a_ workflow-support:839.v35e2736cfd5c ws-cleanup:0.44 xunit:3.1.2

What Operating System are you using (both controller, and any agents involved in the problem)?

CentOS 7

Reproduction steps

1 - create Jenkinsfile in GitLab like:

pipeline { agent any parameters { persistentString(name: 'param1', defaultValue: '123', description: 'Param1') persistentChoice(name: 'param2', choices: ['abc', 'cba'], description: 'Param2')
} stages { stage ('check_param') { } steps { script { println params.param1 println params.param1 } } } } }

2 - create new pipeline in jenkins that look in our Jenkinsfile 3 - configure the build trigger on Poll SCM whith Shedule 4 - disable anonimus access in jenkins 5 - run pipeline manual whith paramets: param1=456 param1=cba (if we run the build manually again, the parameters will be substituted from the previous build correctly) 6 - make any change in the Github repository and wait for the shaduler to work

Expected Results

param1=456 param1=cba

Actual Results

param1=123 param1=abc

Anything else?

if you allow anonymous access, then everything works correctly

wkokolis commented 1 year ago

We see the same behavior when using webhooks instead of SCM polling. Manual runs of the jobs retain the parameters from previous ones, but those triggered by webhooks don't. We cannot afford to allow anonymous access to Jenkins, so this is a fairly major problem.

kerrhome commented 9 months ago

Same issue. We cannot allow anon access.