search

jenkinsci / pipeline-agent-build-history-plugin

Agent Build History with pipeline jobs for Jenkins
https://plugins.jenkins.io/pipeline-agent-build-history/
MIT License
2 stars 2 forks source link

make it compatible with 2.401.1 jenkins #14

Closed Absh-Day closed 5 months ago

Absh-Day commented 5 months ago

Tha parent pom for the plugin is still compatible with 2.3xx.x version so this change should be fine.

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
mawinter69 commented 5 months ago

This can't work. The plugin was already on 2.434 which is newer than what you want. It requires changes in core that were only released with that version.

Absh-Day commented 5 months ago

@mawinter69 Could you tell me features for which this plugin explicitly depends on 2.433 ?

mawinter69 commented 5 months ago

It depends on 2.434 due to this change https://github.com/jenkinsci/jenkins/pull/8705 at least, it might depend on other changes after 2.401 that I use because they were available

Absh-Day commented 5 months ago

It depends on 2.434 due to this change jenkinsci/jenkins#8705 at least, it might depend on other changes after 2.401 that I use because they were available

Great! Thanks for the info.