Improved how it checks for github collaborator access

jenkinsci / pipeline-github-plugin

Pipeline: GitHub

https://plugins.jenkins.io/pipeline-github/

MIT License

159 stars 73 forks source link

Improved how it checks for github collaborator access #111

Closed xocasdashdash closed 1 year ago

xocasdashdash commented 2 years ago

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Should allow closing #107 #104

xocasdashdash commented 2 years ago

Sorry to ping you @aaronjwhiteside , is there any way of speeding up getting this PR merged and a new release cut? not sure who to ping about this and it's been 2+ months since i opened it.

aaronwalker commented 2 years ago

@xocasdashdash sorry it's been a crazy couple of months. I will review this PR and let you know. I think the changes look pretty good though

xocasdashdash commented 2 years ago

@aaronwalker Updated the PR removing the dead code, let me know if there's anything else to do!

xocasdashdash commented 1 year ago

@aaronwalker hey, sorry to ping, do you think this can get merged now?

aaronwalker commented 1 year ago

@aaronwalker hey, sorry to ping, do you think this can get merged now?

Just a quick one before I merge this... Have you tested the Incrementals plugin version https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/pipeline-github/2.8-140.9440018594b6/ ?

xocasdashdash commented 1 year ago

I did not know this existed! Will get back to you once i've validated it!

TueDissingWork commented 1 year ago

UPDATE: works fine with this version: 2.8-140.9440018594b6

Was simple missing correct auth config for the repo on the GitHub app. When using version 2.8-138.d766e30bb08b is also works. Nice!

~~Hey, just tried the mentioned version @aaronwalker, but to avail. Still getting: Comment Author: USERNAME is not a collaborator, and is therefore not authorized to trigger a build., when trying to trigger the build with a comment. I am, as well, part of a team.~~

Job: devops/autochange-pr-flow/PR-1,
IssueComment: GHIssueComment@172b2357[body=test this please,url=https://githuburl/api/v3/repos/org/repo-name/issues/comments/.....],
Comment Author: USERNAME is not a collaborator, and is therefore not authorized to trigger a build.

xocasdashdash commented 1 year ago

Nice! I haven't been able to test it myself but if @TueDissingWork has, let's get this merged! :)

xocasdashdash commented 1 year ago

@aaronwalker are you ok with @TueDissingWork tests?