[JENKINS-68480] Automatically select owner for GitHubAppCredentials

jenkinsci / pipeline-github-plugin

Pipeline: GitHub

https://plugins.jenkins.io/pipeline-github/

MIT License

159 stars 73 forks source link

[JENKINS-68480] Automatically select owner for GitHubAppCredentials #117

Closed LeoQuote closed 1 year ago

LeoQuote commented 1 year ago

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

This pr fix https://issues.jenkins.io/browse/JENKINS-68480 , like https://github.com/jenkinsci/github-branch-source-plugin/pull/527 , it sets RepoOwner() context automatically , make it possible to call api when using github app credentials

LeoQuote commented 1 year ago

Installed plugin in my jenkins instance, it made a comment successfully

LeoQuote commented 1 year ago

@aaronwalker hi, do you have a moment to review and merge this pr?

Multiple dependencies have been upgraded, I believe the Jenkinsfile also needs to be upgraded , I ran the compile on my pc and it works.

aaronwalker commented 1 year ago

@LeoQuote looks like an issue with the CI See https://github.com/jenkinsci/pipeline-github-plugin/runs/12449680268

LeoQuote commented 1 year ago

@aaronwalker Thanks for your review, IMHO the error is caused by the outdated build environtment, the building system is using java 8 which is not supported in the latest jenkins server.

would you consider merging #118 to bring build environment to the latest?

aaronwalker commented 1 year ago

@LeoQuote hate to be a pain but can you squash this into a single commit

LeoQuote commented 1 year ago

@aaronwalker certainly, done.