search

jenkinsci / pipeline-github-plugin

Pipeline: GitHub
https://plugins.jenkins.io/pipeline-github/
MIT License
159 stars 73 forks source link

Include line in review comment API calls #93

Closed tbarda closed 3 years ago

tbarda commented 3 years ago

copied @mollstam PR to fix https://github.com/jenkinsci/pipeline-github-plugin/issues/88

This change sets line instead of position when adding review comments through pullRequest.reviewComment(...) to not have the API call fail with an error.

Seems like GitHub made a change to their API, or I assume this code at one point worked at least, there's an issue upstream about this: jenkinsci#88

tbarda commented 3 years ago

@aaronwalker can you review and merge?

aaronwalker commented 3 years ago

@aaronwalker can you review and merge?

I don't have permissions to merge although @aaronjwhiteside I'd be keen to be added as a maintainer for this plugin

tbarda commented 3 years ago

@aaronwalker can you review and merge?

I don't have permissions to merge although @aaronjwhiteside I'd be keen to be added as a maintainer for this plugin

@aaronjwhiteside can you?

tbarda commented 3 years ago

@aaronjwhiteside can you look at this?