Pipeline Console when logs are more Show more logs button doesn't works

mukeshmgehani commented 1 year ago

Jenkins and plugins versions report

Environment

```text Jenkins: 2.401.1 OS: Linux - 3.10.0-1160.92.1.el7.x86_64 Java: 11.0.18 - Azul Systems, Inc. (OpenJDK 64-Bit Server VM) --- MSDEPlugin:1.0.1 ace-editor:1.1 analysis-model-api:11.3.0 ansicolor:1.0.2 ant:487.vd79d090d4ea_e antisamy-markup-formatter:159.v25b_c67cd35fb_ apache-httpcomponents-client-4-api:4.5.14-150.v7a_b_9d17134a_5 artifact-manager-msde-plugin:0.7.2 artifact-manager-s3:822.vf129d4836c31 audit-trail:333.vb_e1b_b_0f1238c authentication-tokens:1.53.v1c90fd9191a_b_ aws-credentials:191.vcb_f183ce58b_9 aws-global-configuration:108.v47b_fd43dfec6 aws-java-sdk-ec2:1.12.481-392.v8b_291cfcda_09 aws-java-sdk-minimal:1.12.481-392.v8b_291cfcda_09 blueocean:1.27.4 blueocean-autofavorite:1.2.5 blueocean-bitbucket-pipeline:1.27.4 blueocean-commons:1.27.4 blueocean-config:1.27.4 blueocean-core-js:1.27.4 blueocean-dashboard:1.27.4 blueocean-display-url:2.4.2 blueocean-events:1.27.4 blueocean-executor-info:1.27.4 blueocean-git-pipeline:1.27.4 blueocean-github-pipeline:1.27.4 blueocean-i18n:1.27.4 blueocean-jira:1.27.4 blueocean-jwt:1.27.4 blueocean-personalization:1.27.4 blueocean-pipeline-api-impl:1.27.4 blueocean-pipeline-editor:1.27.4 blueocean-pipeline-scm-api:1.27.4 blueocean-rest:1.27.4 blueocean-rest-impl:1.27.4 blueocean-web:1.27.4 bootstrap4-api:4.6.0-6 bootstrap5-api:5.3.0-1 bouncycastle-api:2.28 branch-api:2.1109.vdf225489a_16d build-monitor-plugin:1.12+build.201809061734 build-name-setter:2.2.0 build-pipeline-plugin:1.5.8 build-timeout:1.31 build-user-vars-plugin:1.9 build-with-parameters:76.v9382db_f78962 buildresult-trigger:0.18 built-on-column:1.4 byop-killer:1.2 byop-repair-ws:1.18 caffeine-api:3.1.6-115.vb_8b_b_328e59d8 checks-api:2.0.0 claim:516.v36293563731d cloudbees-bitbucket-branch-source:805.v7f97d29dc0f5 cloudbees-disk-usage-simple:182.v62ca_0c992a_f3 cloudbees-folder:6.815.v0dd5a_cb_40e0e clover:4.13.0 cobertura:1.17 code-coverage-api:4.7.0 command-launcher:90.v669d7ccb_7c31 commons-lang-api:2.6.0 commons-lang3-api:3.12.0-36.vd97de6465d5b_ commons-text-api:1.10.0-36.vc008c8fcda_7b_ concordionpresenter:0.7 conditional-buildstep:1.4.2 config-file-provider:938.ve2b_8a_591c596 configuration-as-code:1647.ve39ca_b_829b_42 copyartifact:705.v5295cffec284 cppcheck:1.26 cpsnotifier:3.0.4 credentials:1254.vb_96f366e7b_a_d credentials-binding:604.vb_64480b_c56ca_ cucumber-reports:5.7.5 customizable-header:16.v46d4fb_fd1722 cvs:2.19.1 dark-theme:336.v02165cd8c2ee dashboard-view:2.487.vcf0ff9008a_c0 data-tables-api:1.13.4-2 description-setter:1.10 display-url-api:2.3.9 docker-commons:419.v8e3cd84ef49c docker-workflow:563.vd5d2e5c4007f downstream-buildview:69.v16da_b_2c36f6c dtkit-api:3.0.2 durable-task:507.v050055d0cb_dd echarts-api:5.4.0-5 email-ext:2.69 embeddable-build-status:385.vc95f94e91fb_3 envinject:2.901.v0038b_6471582 envinject-api:1.199.v3ce31253ed13 extended-read-permission:53.v6499940139e5 external-monitor-job:203.v683c09d993b_9 favorite:2.4.2 flexible-publish:0.16.1 font-awesome-api:6.4.0-1 forensics-api:2.3.0 gating-core:1.2 git:5.1.0 git-client:4.4.0 git-server:99.va_0826a_b_cdfa_d github:1.37.1 github-api:1.314-431.v78d72a_3fe4c3 github-branch-source:1728.v859147241f49 gradle:2.8.2 greenballs:1.15.1 groovy:453.vcdb_a_c5c99890 handlebars:3.0.8 handy-uri-templates-2-api:2.1.8-22.v77d5b_75e6953 htmlpublisher:1.31 http_request:1.16 instance-identity:173.va_37c494ec4e5 ionicons-api:56.v1b_1c8c49374e ivy:2.5 jackson2-api:2.15.2-350.v0c2f3f8fc595 jacoco:3.3.3 jakarta-activation-api:2.0.1-3 jakarta-mail-api:2.0.1-3 javadoc:233.vdc1a_ec702cff javax-activation-api:1.2.0-6 javax-mail-api:1.6.2-9 jaxb:2.3.8-1 jbehave-jenkins-plugin:4.3.5 jdk-tool:66.vd8fa_64ee91b_d jenkins-design-language:1.27.4 jenkins-warlock-plugin:1.5.6 jersey2-api:2.39.1-2 jira:3.10 jjwt-api:0.11.5-77.v646c772fddb_0 job-restrictions:0.8 jobConfigHistory:1229.v3039470161a_d join:1.21 jquery:1.12.4-1 jquery-detached:1.2.1 jquery3-api:3.7.0-1 jsch:0.2.8-65.v052c39de79b_2 junit:1207.va_09d5100410f jvmstats:0.2 ldap:682.v7b_544c9d1512 lockable-resources:1156.v5e9f897ece02 log-parser:2.3.0 logfilesizechecker:1.5 mailer:457.v3f72cb_e015e5 mailerdomain-filter-plugin:1.0 mapdb-api:1.0.9-28.vf251ce40855d matrix-auth:3.1.8 matrix-project:789.v57a_725b_63c79 maven-plugin:3.22 mercurial:1260.vdfb_723cdcc81 metrics:4.2.18-439.v86a_20b_a_8318b_ mina-sshd-api-common:2.10.0-69.v28e3e36d18eb_ mina-sshd-api-core:2.10.0-69.v28e3e36d18eb_ modernstatus:1.3 momentjs:1.1.1 monitoring:1.94.1 msdearty:1.12 msdeharmonynotify:0.9.0 mstest:1.0.0 naginator:1.19.2 nant:248.vcc8a_3eec8db_a nested-view:1.32 nodelabelparameter:1.12.0 nunit:380.va_067eddf00da_ okhttp-api:4.11.0-145.vcb_8de402ef81 opentelemetry:2.17.0 pam-auth:1.10 parameterized-scheduler:1.2 parameterized-trigger:2.45 performance:928.vdea_0dca_55446 pipeline-build-step:496.v2449a_9a_221f2 pipeline-config-history:1.6 pipeline-graph-analysis:202.va_d268e64deb_3 pipeline-graph-view:202.v6da_a_9e590325 pipeline-groovy-lib:656.va_a_ceeb_6ffb_f7 pipeline-input-step:468.va_5db_051498a_4 pipeline-milestone-step:111.v449306f708b_7 pipeline-model-api:2.2141.v5402e818a_779 pipeline-model-definition:2.2141.v5402e818a_779 pipeline-model-extensions:2.2141.v5402e818a_779 pipeline-rest-api:2.33 pipeline-stage-step:305.ve96d0205c1c6 pipeline-stage-tags-metadata:2.2141.v5402e818a_779 pipeline-stage-view:2.32 pipeline-utility-steps:2.15.4 plain-credentials:143.v1b_df8b_d3b_e48 plot:2.1.12 plugin-util-api:3.3.0 popper-api:1.16.1-3 popper2-api:2.11.6-2 postbuild-task:1.9 prism-api:1.29.0-7 private-slave-plugin:1.17 prometheus:2.2.3 promoted-builds:892.vd6219fc0a_efbms pubsub-light:1.17 queue-cleaner:1.3 rebuild:320.v5a_0933a_e7d61 release:2.15 remote-user-auth-plugin:2.0.3 resource-disposer:0.22 rich-text-publisher-plugin:1.4 robot:3.3.0 run-condition:1.5 saferestart:0.7 scm-api:676.v886669a_199a_a_ scoverage:1.4.0 script-security:1251.vfe552ed55f8d shareable-slave-plugin:2.5.9 simple-theme-plugin:160.vb_76454b_67900 snakeyaml-api:1.33-95.va_b_a_e3e47b_fa_4 sse-gateway:1.26 ssh-credentials:305.v8f4381501156 ssh-slaves:2.877.v365f5eb_a_b_eec ssh-steps:2.0.65.vd26b_5b_9b_de4d sshd:3.303.vefc7119b_ec23 structs:324.va_f5d6774f3a_d subversion:2.17.2 tap:2.3 test-results-analyzer:0.4.0 theme-manager:193.vcef22f6c5f2b_ throttle-concurrents:2.13 timestamper:1.25 token-macro:359.vb_cde11682e0c train-jenkins-plugin:3.0.20 train-release-plugin:1.4.24 translation:1.16 treadmill-cloud:0.51 trilead-api:2.84.v72119de229b_7 valgrind:0.28 validating-string-parameter:2.8 variant:59.vf075fe829ccb versionnumber:1.11 warnings-ng:10.2.0 workflow-aggregator:596.v8c21c963d92d workflow-api:1215.v2b_ee3e1b_dd39 workflow-basic-steps:1017.vb_45b_302f0cea_ workflow-cps:3691.v28b_14c465a_b_b_ workflow-cps-global-lib:609.vd95673f149b_b workflow-durable-task-step:1247.v7f9dfea_b_4fd0 workflow-job:1308.v58d48a_763b_31 workflow-multibranch:756.v891d88f2cd46 workflow-scm-step:415.v434365564324 workflow-step-api:639.v6eca_cd8c04a_a_ workflow-support:839.v35e2736cfd5c ws-cleanup:0.45 xunit:3.1.2 xvfb:1.2 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux

Reproduction steps

When you run the job and if it have big size log file in case of test cases logs then you can see Missing of logs with show more log button and when you click on it , it doesn't work and nothing happens.

Expected Results

show more log button should work and logs should not be missing from that log windows.

Actual Results

show more log is not working and some logs are missing from output.

Anything else?

Issue with graph view plugin

rafall92 commented 1 year ago

I also have this problem

donut181 commented 1 year ago

The same for me. Dev tools show the response being returned right away but nothing happens on ui.

vient commented 1 year ago

Same I looked a bit into what's going on and it seems that the problem is here stepBuffer.startByte is passed to to getConsoleTextOffset instead of startByte startByte is the offset we want to get, and stepBuffer.startByte is current offset. The result is fetching the same part of log that is already shown, so nothing changes.

In console it shows as repetition of same log if button is pressed several times

(3) ConsoleLogCard.tsx:74 startByte '528993' -> '375393'

cc @timbrown5 @timja

timja commented 1 year ago

you able to send a pull request?

vient commented 1 year ago

I am not sure that this is the right spot. If this is indeed the only change needed then yes, otherwise I have no experience in TS. For example, I'm not currently able to write test for this.

timbrown5 commented 8 months ago

That sounds right to me. | remember fixing this, but maybe I didn't create a PR 😬

On Tue, 7 Nov 2023, 17:29 vient, @.***> wrote:

I am not sure that this is the right spot. If this is indeed the only change needed then yes, otherwise I have no experience in TS.

— Reply to this email directly, view it on GitHub https://github.com/jenkinsci/pipeline-graph-view-plugin/issues/300#issuecomment-1799294017, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB54FHW3Z434H4XZ4OQPO3YDJVV5AVCNFSM6AAAAAA533LCRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJZGI4TIMBRG4 . You are receiving this because you were mentioned.Message ID: @.***>

jenkinsci / pipeline-graph-view-plugin