jenkinsci / pipeline-graph-view-plugin

https://plugins.jenkins.io/pipeline-graph-view/
Other
106 stars 53 forks source link

Add Date Time to Graph View Pipelines Similar to Stage View #449

Open SaturnIC opened 2 months ago

SaturnIC commented 2 months ago

What feature do you want to see added?

The default Jenkins Pipeline View: Stage View has a date & time stamp in front of each pipeline to easily see when the pipelines were triggered in the list of pipelines.

In Graph View the pipelines only have a build number in the pipeline overview but no date or time which makes it more complicated to find out when each pipeline did run.

So please add Date and Time information in front of the build number of each pipeline.

JenkinsPipelineDate

Upstream changes

No response

Are you interested in contributing this feature?

Sure

lroubeyrie-ingenico commented 2 months ago

+1 for this one, with the change information

SaturnIC commented 2 months ago

Also the pipeline build duration would be a nice to have information for each pipeline in the pipeline overview

mr-remington commented 2 months ago
Screenshot 2024-06-25 at 1 52 06 PM

Something like this perhaps? I started briefly on it but stopped on the change sets. I could do a direct rip off of stage view but there must a design that's cleaner? Im debating perhaps a third column on the far right w/ change info

Also it doesn't seem to be passing running stage status to the pipeline column which I'd like to address

lroubeyrie-ingenico commented 2 months ago

Maybe the change info could be under or inside the "Start" point, and the total duration on the "End"

SaturnIC commented 2 months ago

Something like this perhaps? I started briefly on it but stopped on the change sets. I could do a direct rip off of stage view but there must a design that's cleaner? Im debating perhaps a third column on the far right w/ change info

That looks nice, would be great already, any optimization to that design could be added later? So just do it like that?

timja commented 2 months ago

Keep in mind that the #1 is not always a build number, people can change set the build display name -.-. Which can make things like this more complicated

mr-remington commented 2 months ago

@timja you're right. In my first screencap i was relying on the existing svg icon logic to set that little thing in the ID field which wont work if someone gets verbose. So I've dropped it and now rely on purely CSS(however we lose running animations):

Screenshot 2024-06-27 at 7 12 08 PM

I've also incorporated a duration column so we have room to shove change cause under the ID column right under start time

mr-remington commented 1 month ago

Apologies for the delay, I wasnt quite happy with the design above so I moved things into Material and leveraged some of the svg stuff used in other parts for uniformity. Trying to account for everyone...:

With long build names I'm truncating them down a bit with an ellipsis(slightly better then what stage view does):

Screenshot 2024-07-22 at 9 22 15 PM

The first line with the status circles and build ids are clickable, on hover we get long format along with durations

Screenshot 2024-07-22 at 9 22 46 PM

For localization I'm relying purely on the browser tells us about the user. After this I'm thinking adding change cause below the short time in the ID column so everything is top aligned in prep for having more in there. Thoughts/comments/flames before I clean up the PR code?

timja commented 1 month ago

Unstable is unreadable in dark theme: image


Time display changes from 24 hour clock to 12 hour on the tooltip which is a bit jarring: image


Long build display names seem to be allowed to just push content across rather than wrapping or being truncated (not sure why I'm not getting the same behaviour as you):

image


For localization I'm relying purely on the browser tells us about the user

Might be ok, ideally it would use their Jenkins preferences as that will be consistent throughout, they may have their computer configured to e.g. UTC+1 but work mostly with people in UTC so show UTC times to make communication easier (maybe)


Ha thought I was on the PR I guess you haven't quite pushed everything for e.g. the truncation?