jenkinsci / pipeline-graph-view-plugin

https://plugins.jenkins.io/pipeline-graph-view/
Other
109 stars 56 forks source link

Fix PCT Test #498

Closed mtughan closed 2 months ago

mtughan commented 2 months ago

HtmlUnit does not appear to support the [key] syntax for setting property IDs in ECMAScript objects. To work around this, create an object specifically for the request headers and set the property using the standard syntax instead of setting it during object creation.

Fixes an issue introduced by #491 and will allow jenkinsci/bom#3524 to be merged.

Testing done

Tested locally using the PCT on the weekly line. Was failing before this change and succeeds afterwards.

Submitter checklist

mtughan commented 2 months ago

@basil and @timja: not specifically related to this fix, but Linux-based executors seem to be stuck on https://ci.jenkins.io/. Can someone investigate that?