search

jenkinsci / plasticscm-plugin

A plugin for Jenkins to be able to use Plastic SCM
MIT License
16 stars 31 forks source link

Jenkins plugin changes for Plastic SCM 4.0 #1

Closed ravelus closed 12 years ago

ravelus commented 12 years ago

I've changed the Jenkins plugin for Plastic SCM 4.0.

This version is necessary to work with Plastic SCM 4.0, and it's not compatible with Plastic SCM 3.0.

I would like it to be merged in the next Jenkins release.

Thanks, Luis

dickp commented 12 years ago

On 12/01/2012 11:06 AM, ravelus wrote:

I've changed the Jenkins plugin for Plastic SCM 4.0.

This version is necessary to work with Plastic SCM 4.0, and it's not compatible with Plastic SCM 3.0.

I would like it to be merged in the next Jenkins release.

Hi Luis

I'll email the jenkins list to try and get you assigned as the plugin maintainer. You'll need to sign up for a Jenkins account first (see https://wiki.jenkins-ci.org/display/JENKINS/User+Account+on+Jenkins). If you haven't already done so, also have a look at the plugin hosting doc here: https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins

Let me know your jenkins ID when you've done that, and I'll email the list.

Regarding the incompatible changes, I suggest you fork the plugin into a plasticscm4-plugin and keep the old one compatible with v3.

ravelus commented 12 years ago

Hi, Dick; how are you doing?

El 12/01/2012 12:57, dickp escribió:

On 12/01/2012 11:06 AM, ravelus wrote:

I've changed the Jenkins plugin for Plastic SCM 4.0.

This version is necessary to work with Plastic SCM 4.0, and it's not compatible with Plastic SCM 3.0.

I would like it to be merged in the next Jenkins release. Hi Luis

I'll email the jenkins list to try and get you assigned as the plugin maintainer. You'll need to sign up for a Jenkins account first (see https://wiki.jenkins-ci.org/display/JENKINS/User+Account+on+Jenkins). If you haven't already done so, also have a look at the plugin hosting doc here: https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins

Let me know your jenkins ID when you've done that, and I'll email the list. I already did so yesterday :-). This is my ID:

lrodriguez

I also updated the pom.xml file where your user was specified, so that I'm the new responsible for the plugin.

So, once you get me assigned as the plugin maintainer I'll need to do something else (such as a pull request on the jenkins github, email the administrators, do a fork on jenkins github...) or they will get my changes directly? According to the hosting doc, we already have a plugin repository, so just sending them my ID and telling them where our repository is sounds good enough, right?

Regarding the incompatible changes, I suggest you fork the plugin into a plasticscm4-plugin and keep the old one compatible with v3. Thanks for your suggestion, I think you have a point, but we want to move forward with the Plastic SCM 4 migration on our clients and we've decided that in case that the changes in the plugins make them incompatible with older versions we'll keep the version compatible with Plastic SCM 4.

  • Dick

Reply to this email directly or view it on GitHub: https://github.com/jenkinsci/plasticscm-plugin/pull/1#issuecomment-3461985

Thanks a lot and take care, Dick!

Luis Rodríguez Neches Software Engineer www.codicesoftware.com http://www.codicesoftware.com

Plastic SCM by Codice Software http://www.plasticscm.comhttp://www.plasticscm.com

dickp commented 12 years ago

On 12/01/2012 12:33 PM, ravelus wrote:

Hi, Dick; how are you doing?

Not so bad, thanks :)

I already did so yesterday :-). This is my ID:

lrodriguez

I also updated the pom.xml file where your user was specified, so that I'm the new responsible for the plugin.

Cool.

So, once you get me assigned as the plugin maintainer I'll need to do something else (such as a pull request on the jenkins github, email the administrators, do a fork on jenkins github...) or they will get my changes directly? According to the hosting doc, we already have a plugin repository, so just sending them my ID and telling them where our repository is sounds good enough, right?

You'd have commit privileges on the plastic plugin repo in the jenkins github project.

Regarding the incompatible changes, I suggest you fork the plugin into a plasticscm4-plugin and keep the old one compatible with v3. Thanks for your suggestion, I think you have a point, but we want to move forward with the Plastic SCM 4 migration on our clients and we've decided that in case that the changes in the plugins make them incompatible with older versions we'll keep the version compatible with Plastic SCM 4.

You might get some push-back from the jenkins maintainers if you break compatibility with existing installations. That's why I suggested leaving plasticscm-plugin as is, and calling the new version plasticscm4-plugin.

ravelus commented 12 years ago

Ok, I'll take that into account, and fork the project if necessary.

Thanks a lot, Dick.

El 12/01/2012 13:48, dickp escribió:

You might get some push-back from the jenkins maintainers if you break compatibility with existing installations. That's why I suggested leaving plasticscm-plugin as is, and calling the new version plasticscm4-plugin.

Luis Rodríguez Neches Software Engineer www.codicesoftware.com http://www.codicesoftware.com

Plastic SCM by Codice Software http://www.plasticscm.comhttp://www.plasticscm.com