search

jenkinsci / plasticscm-plugin

A plugin for Jenkins to be able to use Plastic SCM
MIT License
16 stars 31 forks source link

Output XML directly to file #36

Closed mig42 closed 3 years ago

mig42 commented 3 years ago

Fix XML parser issues with really long XML streams.

We noticed that the output of commands cm log or cm find could choke the parser if the stream got too long (like 50 MiB).

This PR will take advantage of the Plastic CLI arguments to make the commands write the XML output directly to a file instead of stdout. This way the parser can process files on its own, without worrying about overflowing the process buffers.

knapsu commented 3 years ago

This change is broken. It should not have been merged.

It works only if executing a build on Jenkins master node. It will give NullPointerException if build job is executed on any Jenkins Agent node. The reason will be missing XML file.

Suggesting to revert this change completely.

mig42 commented 3 years ago

Oh my, I'll have a look at it next morning to have it fixed ASAP. Since this doesn't hit users because it's not released, we don't need to disintegrate the PR.