switch maven project list to :artifactId from modulePath

[ampuscas]

Related to https://github.com/jenkinsci/maven-hpi-plugin/issues/497

the upstream issue creates failures like Caused by: java.io.IOException: org.codehaus.plexus.util.xml.pull.XmlPullParserException: Expected root element 'project' but ``found 'projects' (position: START_TAG seen ...=================================================== -->\n<projects>... @8:11)

By switching from using a module path (from maven-hpi) to a :artifactId representation we do not realy on metadata to be correct other than the artifactId, which should always be correct for a maven project!

With these modifications, the tests for the multi-module plugin warnings-ng run normally, tested with this command:

java -Xmx1g -jar plugin-compat-tester/target/plugins-compat-tester-cli.jar test-plugins --war=jenkins.war --include-plugins=warnings-ng

Testing done

Submitter checklist

• [ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [ ] Ensure that the pull request title represents the desired changelog entry
• [ ] Please describe what you did
• [ ] Link to relevant issues in GitHub or Jira
• [ ] Link to relevant pull requests, esp. upstream and downstream changes
• [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jtnord]

LocalCheckoutPluginMetadataExtractor should probably be updated to also use :pluginId

[jtnord]

So this looks like https://github.com/jenkinsci/bom/pull/2146 did not actually run any tests so did not sanity check the change.

@basil can you sanity check this please in the context of the bom please?

[basil]

Seems fine I guess. I did not test this in BOM.