jenkinsci / plugin-compat-tester

Jenkins Plugin Compatibility Tester
MIT License
46 stars 55 forks source link

Fix `--no-fail-fast` option #663

Closed basil closed 5 months ago

basil commented 5 months ago

While trying to use --no-fail-fast, I discovered it didn't actually work. Reading the documentation, it says:

Negatable options that are true by default

When a negatable option is true by default, give it both a defaultValue and a fallbackValue of "true".

Doing as the documentation suggested fixed the bug.

Testing done

Interactively tested with both --fail-fast (fails fast), --no-fail-fast (now does not fail fast, which is the bug fix), and no option (maintains the existing behavior of failing fast).