search

jenkinsci / plugin-pom

Parent POM for Jenkins Plugins
https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial
MIT License
68 stars 77 forks source link

Upgrade htmlunit to 3.3.0 #777

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps jenkins-test-harness from 2007.v8f9e5c18335a_ to 2010.v1888f1acd45a.

Release notes

Sourced from jenkins-test-harness's releases.

2010.v1888f1a_cd45a_

💥 Breaking changes

🚦 Tests

📦 Dependency updates

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @timja.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
timja commented 1 year ago

@dependabot squash and merge

timja commented 1 year ago

Does not

https://github.com/jenkinsci/plugin-pom/blob/ee4ae0a5be4e49aeed5c736a294368afafc32b5b/pom.xml#L1102

also need to be updated in lockstep with this change?

~From my reading it's actually dead code as the bug was fixed, I would have expected to have hit the issue by now if it was still necessary so I'll file a PR to remove it.~

Apparently there's another parser that says it's been fixed but HtmlUnit is using the the original project.

I checked in workflow-job where there was originally seen and it's still an issue, (although just causing log spam).

dTooLargeException: Method too large: org/htmlunit/css/StyleAttributes$Definition.<clinit> ()V
    at org.jacoco.agent.rt.internal_4a7f17c.asm.MethodWriter.computeMethodInfoSize(MethodWriter.java:2088)
    at org.jacoco.agent.rt.internal_4a7f17c.asm.ClassWriter.toByteArray(ClassWriter.java:511)
    at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:92)
    at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:109)
    ... 55 more
timja commented 1 year ago

👉 https://github.com/jenkinsci/plugin-pom/pull/778