jenkinsci / plugin-pom

Parent POM for Jenkins Plugins
https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial
MIT License
67 stars 75 forks source link

`yarn mvntest` failures ignored in CI #874

Open jglick opened 7 months ago

jglick commented 7 months ago

In https://github.com/jenkinsci/workflow-cps-plugin/pull/821 I struggled to figure out how this ever passed in CI. Turns out

mvn verify -Dtest=InjectedTest -Dmaven.test.failure.ignore

prints ESLint failures but passes anyway. https://github.com/eirslett/frontend-maven-plugin#ignoring-failure does not say where test failures would be recorded. Based on inspecting sources, they are not recorded anywhere at all, so using junit is not enough. I think this mojo parameter needs to be disabled in the POM so that maven.test.failure.ignore applies only to Surefire.