search

jenkinsci / prometheus-plugin

Jenkins Prometheus Plugin
https://plugins.jenkins.io/prometheus/
Apache License 2.0
181 stars 151 forks source link

Fix typos in metrics doc #662

Closed avlitman closed 3 months ago

avlitman commented 4 months ago

metrics doc contain names with double underscore.

Fixes #...

Changes proposed

Checklist

Notify

@Waschndolos

avlitman commented 3 months ago

@Waschndolos Oh I see you changes it here https://github.com/jenkinsci/prometheus-plugin/commit/304ce257bcb3e2864619591d774bfa4b76e7110e after I opened this pr..

BTW i still think default_jenkins_builds_<buildname>_last* is not correct in my case, it's only default_jenkins_builds_last* for my endpoint.

Waschndolos commented 3 months ago

Thanks for reaching back. I'll need to test this again - maybe I'm overseeing something here

Waschndolos commented 3 months ago

I'll go ahead and close this PR and fix the documentation in https://github.com/jenkinsci/prometheus-plugin/issues/666 . Guess it's too confusing right now