search

jenkinsci / publish-over-ftp-plugin

https://plugins.jenkins.io/publish-over-ftp/
21 stars 33 forks source link

[JENKINS-16681] Publish Over FTP 1.8 not working with spaces in filename/path of source files #43

Closed jira-importer closed 11 years ago

jira-importer commented 11 years ago

"Transfer Set"/"Source Files" does not support spaces.

I want to transfer something like
Project/Output/Install Product.exe
Or possibly:
Project Output/*.exe

Quoting the path does not help.

Originally reported by fatpete, imported from: Publish Over FTP 1.8 not working with spaces in filename/path of source files
  • assignee: bap
  • status: Resolved
  • priority: Critical
  • resolution: Fixed
  • resolved: 2013-02-11T11:05:22+11:00
  • imported: 2022/01/10
jira-importer commented 11 years ago

scm_issue_link:

Code changed in jenkins
User: bap2000
Path:
src/main/java/jenkins/plugins/publish_over_ftp/BapFtpTransfer.java
src/main/java/jenkins/plugins/publish_over_ftp/descriptor/BapFtpTransferDescriptor.java
src/main/java/jenkins/plugins/publish_over_ftp/options/FtpOverrideTransferDefaults.java
src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpTransfer/config.jelly
src/main/resources/jenkins/plugins/publish_over_ftp/BapFtpTransfer/help-patternSeparator.html
src/main/resources/jenkins/plugins/publish_over_ftp/options/FtpOverrideTransferDefaults/config.jelly
src/test/java/jenkins/plugins/publish_over_ftp/jenkins/CurrentConfigurationTest.java
src/test/java/jenkins/plugins/publish_over_ftp/jenkins/IntegrationTest.java
src/test/java/jenkins/plugins/publish_over_ftp/jenkins/LegacyConfigurationTest.java
http://jenkins-ci.org/commit/publish-over-ftp-plugin/a972ce7c0c4d6695e7a80aa5de96f3e833e04d9a
Log:
[FIXED JENKINS-16681] Don't let Ant separate the patterns - and allow the separator regex to be configured to enable patterns with spaces in them

–
You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

jira-importer commented 11 years ago

ventuz:

Okay, it should have been obvious but I didn't find it right away: it now works, but one has to change the separator pattern in the advanced options from "[, ]" to "[,]". Otherwise the whitespace is still interpreted as a possibility to split the string into multiple parts. Perhaps the default pattern should be changed?