search

jenkinsci / publish-over-ftp-plugin

https://plugins.jenkins.io/publish-over-ftp/
21 stars 33 forks source link

Adapt for Jenkins 2.264+ usage of div-based layout. #8

Closed bdragon28 closed 3 years ago

bdragon28 commented 3 years ago

Adapted from the JENKINS-64078 fix.

This fixes scrambled layout when running on Jenkins 2.264 and newer.

bdragon28 commented 3 years ago

Hmm, interface is still broken for creation. Tinkering some more.

kamaliang commented 3 years ago

Hi, have you solved this problem already ? I also had this problem, can you please share? Thank you very much !!!

bdragon28 commented 3 years ago

I haven't gotten around to debugging the creation interface yet, sorry for the delay.

It was low priority for me as I'm using jenkins job builder to do job creation. Will try to get to it sometime this weekend.

bdragon28 commented 3 years ago

Strange, I'm now not able to reproduce the problem I was having with the creation interface. Maybe there's some caching related problem that was causing it.

JustOneMoreBlock commented 3 years ago

@bdragon28 Any updates? We are having the same issue preventing us from saving.

kamaliang commented 3 years ago

Strange, I'm now not able to reproduce the problem I was having with the creation interface. Maybe there's some caching related problem that was causing it.

Hi, i cleaned the browser's cache , all the job using the publish-over-ftp-plugin still have this problem, confusing~

JustOneMoreBlock commented 3 years ago

@bdragon28 Any updates? We are having the same issue preventing us from saving.

I just compiled @bdragon28 version. You can find the hpi file and upload it.

Works fine for me.

oleg-nenashev commented 3 years ago

My bad. I have merged https://github.com/jenkinsci/publish-over-ftp-plugin/pull/9 without noticing this PR

oleg-nenashev commented 3 years ago

Basically the changes are identical. I will close this one, because #9 has been already merged. Anyway, thanks a lot for your contribution @bdragon28 ! Will be more careful with merges