jenkinsci / publish-over-ssh-plugin

https://plugins.jenkins.io/publish-over-ssh/
117 stars 150 forks source link

Can't use Chinese as server name #240

Closed liuweiGL closed 2 years ago

liuweiGL commented 2 years ago

Jenkins and plugins versions report

Environment ```text Jenkins: 2.332.1 OS: Linux - 5.4.0-58-generic --- publish-over:0.22 publish-over-ssh:1.24 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

Windows 10

Reproduction steps

Configure the SSH Servers

Expected Results

Showing original Chinese name:

image

Actual Results

Chinese is escaped to Unicode:

image

Anything else?

Why this is necessary:

https://github.com/jenkinsci/publish-over-ssh-plugin/commit/cdfeea74f3c01980856ac46ef28bdbc3fdda132d

yangweijie commented 2 years ago

same

Jmingzi commented 2 years ago

pr 文件修改,取名字的时候应该 unescape 才对。 降级到 1.23 吧。

gmcdonald commented 2 years ago

@liuweiGL - Are you saying this is a regression introduced in https://github.com/jenkinsci/publish-over-ssh-plugin/commit/cdfeea74f3c01980856ac46ef28bdbc3fdda132d ?

liuweiGL commented 2 years ago

yes

derline commented 2 years ago

same. This is a bug for Chinese characters.

gmcdonald commented 2 years ago

@olamy can you look into this, apparantly your removal of some loc at https://github.com/jenkinsci/publish-over-ssh-plugin/pull/61/files has caused this.

derline commented 2 years ago

@olamy Please!

liunancun commented 1 year ago

@liuweiGL hi, Can this fix be compiled separately for a version of jdk8? Jenkins version 2.346.3 cannot install version 1.25 of this.

derline commented 1 year ago

@liuweiGL hi, Can this fix be compiled separately for a version of jdk8? Jenkins version 2.346.3 cannot install version 1.25 of this.

准备找 jenkins 替代品吧,它太老了。

derline commented 1 year ago

我已经放弃这家伙了

olamy commented 1 year ago

@liuweiGL hi, Can this fix be compiled separately for a version of jdk8? Jenkins version 2.346.3 cannot install version 1.25 of this.

@liunancun 2.346.3 is old now and suffers from few security issues. Maybe you should have a look at upgrading your Jenkins version? The minimum required now is 2.361.4 Does something prevent you from upgrading?