search

jenkinsci / publish-over-ssh-plugin

https://plugins.jenkins.io/publish-over-ssh/
115 stars 150 forks source link

Replace Prototype.js with native JavaScript #314

Closed basil closed 1 year ago

basil commented 1 year ago

See this blog post for details. Prototype will eventually be removed from Jenkins core. To prepare for this transition, this plugin must be migrated away from Prototype. Accordingly, this PR removes any usages of Prototype in favor of native JavaScript.

To test this PR, I enabled the user experimental flag to remove Prototype and put breakpoints on each changed line. I then added two SSH servers in the Configure page, one with exec enabled and one without. I stepped through all the changed lines of JavaScript in a Freestyle project configuration page, including switching servers from one with exec enabled to one without, and I verified all the changed lines executed successfully with no console log errors.

Fixes #306

basil commented 1 year ago

CC @jenkinsci/core-security-review

gmcdonald commented 1 year ago

testing locally

gmcdonald commented 1 year ago

all looks good thank you

basil commented 1 year ago

Thank you @gmcdonald. Could this please be released?

gmcdonald commented 1 year ago

Yep will do over the next couple of days