[JENKINS-74017] Extract inline script block from `BapSshPublisherPlugin/config.jelly`

jenkinsci / publish-over-ssh-plugin

https://plugins.jenkins.io/publish-over-ssh/

117 stars 150 forks source link

[JENKINS-74017] Extract inline script block from `BapSshPublisherPlugin/config.jelly` #361

Closed yaroslavafenkin closed 4 weeks ago

yaroslavafenkin commented 4 weeks ago

https://issues.jenkins.io/browse/JENKINS-74017

Testing done

Added 2 SSH servers on the Global Configuration page. Went to create a freestyle project. The affected script block is executed upon entering the page. I've checked whether the values and value types stored inside the global variable are the same before and after the change.

Before the change After the change

Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

basil commented 4 weeks ago

@gmcdonald Can this please be released? That will get us one step closer to marking this plugin as finished in the CSP compatibility project tracking spreadsheet. If that is not practical, please let me know if I should adopt this plugin. Thanks!

gmcdonald commented 4 weeks ago

Thanks @basil, I will see about getting it done , will aim for the weekend if that is ok ?

basil commented 4 weeks ago

Sure, thank you!

basil commented 1 week ago

@gmcdonald Gentle ping that we're still interested in a release. BTW setting up https://www.jenkins.io/doc/developer/publishing/releasing-cd/ would make this less of a personal effort.

gmcdonald commented 1 week ago

Thanks @basil will try and migrate to CD releasing tomorrow. My only concern was about how to interact with the parent publish-over plugin if that affects things at all when it comes time to release a new version of that (and perhaps even a new release of that could auto-bump dependant plugins with its new version number !?)

basil commented 1 week ago

There shouldn't be any negative interactions with dependent plugins when adopting CD. Dependabot is enabled for this repository, so you should get a dependabot PR when the parent plugin is released again.

gmcdonald commented 1 week ago

PRs created for adopting CD -

https://github.com/jenkinsci/publish-over-ssh-plugin/pull/363 https://github.com/jenkins-infra/repository-permissions-updater/pull/4181